Fix cluster routing of various commands #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- many operations were working by following `-MOVED`, which is inefficient (and causes a topology fetch for every miss, due to panic) - change tests to disable `-MOVED` redirection; in tests, failure is preferable
uglide
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally spotted in
FT.SUG*commands, but investigation showed other commands are impacted. Correct routing needs the key to be specified asRedisKey.-MOVED, which is inefficient (and causes a topology fetch for every miss, due to panic)-MOVEDredirection; in tests, failure is preferableFT.SUG*tests on cluster+standaloneSkipClusterPre8skips forFT.*tests; these were previously working on pre-v8 via-MOVED, but now can be routed anywhere - we don't want to support 2 code paths there - just grandfather the tests